← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~wallyworld/launchpad/sprite-icon-spacing-1007263 into lp:launchpad

 

I have introduced a new css class 'actionicon' which provides the required left margin.
Where   were removed before the anchors in the markup, I have added the new css class to the anchors. 
I have also done some drive bt fixes on the product index page - the programming languages edit icon wrapped and there was no space between the Whiteboard text and it's edit icon. To fix the programming languages rendering, I enhanced the lazjs BooleanChoiceWidget and TextLineEditorWidget to accept a css_class init parameter as well as a tag parameter. Then the places that need the spacing just construct the widget with css_class='actionicon'.

I had to use a   to fix the Whiteboard edit icon since modifying the underlying widget insfrastructure affected other icons and this was the most expedient point solution.

-- 
https://code.launchpad.net/~wallyworld/launchpad/sprite-icon-spacing-1007263/+merge/108291
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References