launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Review: Needs Fixing

<wallyworld_> StevenK: TestBranchSubscriptionAddOtherView could iterate over all types of open team and test with each one
<wallyworld_> StevenK: also getVisibleArtifacts - you have the return tuple mixed up
<wallyworld_> StevenK: also, there are no legacy branch triggers so that check isn't needed
<wallyworld_> StevenK: and so the reason the test_subscribe_gives_access test passes is that the branch collection assumes subscribed = visible
<wallyworld_> so that bit of code is sort of pointless atm
-- 
https://code.launchpad.net/~stevenk/launchpad/branch-subscribe-aag/+merge/108881
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.