launchpad-reviewers team mailing list archive

["j.c.sackett" <jcsackett@xxxxxxxxxxxxx>]

j.c.sackett has proposed merging lp:~jcsackett/launchpad/darker-grays into lp:launchpad with lp:~jcsackett/launchpad/better-status-colors as a prerequisite.

Requested reviews:
  Curtis Hovey (sinzui)

For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/darker-grays/+merge/109042

Summary
=======
In fixing the colors in choiceedit for bug status, we discovered we had
several grays that were outside of the expected contrast requirements to be
standards compliant. This branch darkens those color to the maximum allowed
brightness of gray on white to be standards compliant.

Preimp
======
Spoke with Curtis Hovey.

Implementation
==============
Anything above #666 was changed to #666, per standards. I can go through the
process of creating screenshots, but these were all gray on white issues, and
almost all were status colors (e.g. MP status, bug status).

Tests
=====
None.

QA
==
None.

LoC
===
This is LoC neutral.

Lint
====
Our css linter and our css formats don't appear to agree; almost every line
has a problem. As this branch just changes one value for another, no *new*
lint errors have been introduced.

We should probably fix our CSS or fix our linter.
-- 
https://code.launchpad.net/~jcsackett/launchpad/darker-grays/+merge/109042
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'lib/canonical/launchpad/icing/css/colours.css'
--- lib/canonical/launchpad/icing/css/colours.css	2012-06-06 21:55:24 +0000
+++ lib/canonical/launchpad/icing/css/colours.css	2012-06-06 21:55:25 +0000
@@ -230,7 +230,7 @@
     color: red;
     }
 .voteABSTAIN {
-    color: #bebebe;
+    color: #666;
     }
 .votePENDING {
     color: #f60;
@@ -253,7 +253,7 @@
     color: black;
     }
 .mergestatusSUPERSEDED, .mergestatusSUPERSEDED a {
-    color: #bebebe;
+    color: #666;
     }
 .codeimportNEW {
     color: #930;
@@ -314,7 +314,7 @@
     color: red;
     }
 .distromirrorstatusUNKNOWN {
-    color: #bebebe;
+    color: #666;
     }
 .buildstatusNEEDSBUILD {
     color: gray;

=== modified file 'lib/canonical/launchpad/icing/css/forms.css'
--- lib/canonical/launchpad/icing/css/forms.css	2012-03-20 03:01:07 +0000
+++ lib/canonical/launchpad/icing/css/forms.css	2012-06-06 21:55:25 +0000
@@ -71,7 +71,7 @@
 .formHelp {
     max-width: 45em;
     margin: 0.2em 0 0.5em 0.2em;
-    color: #777;
+    color: #666;
     }
 .listbox {
     /* a scrolling list of checkboxes or radio buttons */