launchpad-reviewers team mailing list archive

[Francesco Banconi <francesco.banconi@xxxxxxxxxxxxx>]

Francesco Banconi has proposed merging lp:~frankban/launchpad/bug-1003040-again into lp:launchpad.

Requested reviews:
  Yellow Squad (yellow)
Related bugs:
  Bug #1003040 in Launchpad itself: "lp.services.webapp.tests.test_error.TestDatabaseErrorViews.test_disconnectionerror_view_integration fails intermittently/rarely in parallel tests"
  https://bugs.launchpad.net/launchpad/+bug/1003040

For more details, see:
https://code.launchpad.net/~frankban/launchpad/bug-1003040-again/+merge/109128

== Changes ==

Increased retries because this failure was seen again on a parallel tests run with 32 cores.

No QA

-- 
https://code.launchpad.net/~frankban/launchpad/bug-1003040-again/+merge/109128
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'lib/lp/services/webapp/tests/test_error.py'
--- lib/lp/services/webapp/tests/test_error.py	2012-05-30 15:58:14 +0000
+++ lib/lp/services/webapp/tests/test_error.py	2012-06-07 12:39:20 +0000
@@ -66,7 +66,7 @@
         else:
             self.fail("We should have gotten an HTTP error")
 
-    def retryConnection(self, url, retries=10):
+    def retryConnection(self, url, retries=60):
         """Retry to connect to *url* for *retries* times.
 
         Return the file-like object returned by *urllib2.urlopen(url)*.