launchpad-reviewers team mailing list archive

[Francesco Banconi <francesco.banconi@xxxxxxxxxxxxx>]

Francesco Banconi has proposed merging lp:~frankban/launchpad/bug-1011847 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1011847 in Launchpad itself: "lp.services.webapp.tests.test_error.TestDatabaseErrorViews.test_disconnectionerror_view_integration fails intermittently/rarely in parallel tests"
  https://bugs.launchpad.net/launchpad/+bug/1011847

For more details, see:
https://code.launchpad.net/~frankban/launchpad/bug-1011847/+merge/109789

= Summary =

The failure is similar to what already seen in bug 1003040. This time the SERVICE_UNAVAILABLE error is raised while trying to connect to the url before (and not after) the bouncer is stopped.

== Changes ==

Added retryConnection to that part too.

== Tests ==

bin/test -cvvt lp.services.webapp.tests.test_error.TestDatabaseErrorViews.test_disconnectionerror_view_integration

No QA
-- 
https://code.launchpad.net/~frankban/launchpad/bug-1011847/+merge/109789
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~frankban/launchpad/bug-1011847 into lp:launchpad.

=== modified file 'lib/lp/services/webapp/tests/test_error.py'
--- lib/lp/services/webapp/tests/test_error.py	2012-06-07 12:08:47 +0000
+++ lib/lp/services/webapp/tests/test_error.py	2012-06-12 09:33:41 +0000
@@ -91,7 +91,7 @@
         self.useFixture(bouncer)
         # Verify things are working initially.
         url = 'http://launchpad.dev/'
-        urllib2.urlopen(url)
+        self.retryConnection(url)
         # Now break the database, and we get an exception, along with
         # our view.
         bouncer.stop()