launchpad-reviewers team mailing list archive

[Graham Binns <graham@xxxxxxxxxxxxx>]

Review: Approve code


Benji asked me to take a look at this:

    * At the end of the expiration job's cleanup, it deletes the
      commercial subscription if the project is open source.
      * The project will be ignored by subsequent runs of commercial jobs
        because they only search for projects with commercial subscriptions.

I think that this is safe enough, given that the project isn't being switched to an OS license at this point (IIUC, anyway); it's just a cleanup-if-this-happens-to-be-the-case clause so I'm happy with it.
-- 
https://code.launchpad.net/~sinzui/launchpad/uncommercial-projects/+merge/109404
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.