launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Review: Approve code

This looks excellent. My only concern is on lines 48-49 you call ._showFailed() on the widget and then update the privacy portlet, whereas on lines 108-109, you update the privacy portlet and then call .showSuccessful().
-- 
https://code.launchpad.net/~wallyworld/launchpad/bug-javascript-1011611/+merge/109966
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.