launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/indeterminate-test into lp:maas.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jtv/maas/indeterminate-test/+merge/110244

This test was passing by accident.  I had probably written it without realizing that objects needed to be reloaded before checking them, and then updated it to reload those objects but left in the assumption that the objects would be in the same order as before.  There is no such guarantee in reload_objects.


Jeroen
-- 
https://code.launchpad.net/~jtv/maas/indeterminate-test/+merge/110244
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/indeterminate-test into lp:maas.

=== modified file 'src/maasserver/tests/test_api.py'
--- src/maasserver/tests/test_api.py	2012-06-11 08:46:01 +0000
+++ src/maasserver/tests/test_api.py	2012-06-14 06:51:23 +0000
@@ -925,7 +925,7 @@
         self.assertEqual(
             [httplib.CONFLICT] * len(unreleasable_statuses),
             [response.status_code for response in responses])
-        self.assertEqual(
+        self.assertItemsEqual(
             unreleasable_statuses,
             [node.status for node in reload_objects(Node, nodes)])