launchpad-reviewers team mailing list archive

[Francesco Banconi <francesco.banconi@xxxxxxxxxxxxx>]

Francesco Banconi has proposed merging lp:~frankban/launchpad/bug-1012799 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1012799 in Launchpad itself: "lp.testing.tests.test_testing.TestFeatureFlags.test_set_feature_flags_raises_if_not_available fails intermittently/rarely in parallel tests"
  https://bugs.launchpad.net/launchpad/+bug/1012799

For more details, see:
https://code.launchpad.net/~frankban/launchpad/bug-1012799/+merge/110259

= Summary =

TestFeatureFlags.test_set_feature_flags_raises_if_not_available fails intermittently/rarely if run in isolation.

== Fix ==

Check features exists as an attribute of local thread before deleting it.

== Tests ==

bin/test -cvvt lp.testing.tests.test_testing.TestFeatureFlags.test_set_feature_flags_raises_if_not_available

NO QA
-- 
https://code.launchpad.net/~frankban/launchpad/bug-1012799/+merge/110259
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~frankban/launchpad/bug-1012799 into lp:launchpad.