launchpad-reviewers team mailing list archive

[Benji York <benji@xxxxxxxxxxxxx>]

Benji York has proposed merging lp:~benji/launchpad/bug-1011793-2 into lp:launchpad.

Requested reviews:
  Benji York (benji)
Related bugs:
  Bug #1011793 in Launchpad itself: "lib/lp/services/profile/profiling.txt fails rarely/intermittently in parallel tests"
  https://bugs.launchpad.net/launchpad/+bug/1011793

For more details, see:
https://code.launchpad.net/~benji/launchpad/bug-1011793-2/+merge/110338

Bug 1011793 is about a test failing when run in parallel because the
"logs" directory doesn't exist. It turns out that the "logs" directory
gets created as a side effect of starting Launchpad or running
particular tests.

Instead, this branch simply creates the directory so development and
test environments won't have to depend on side effects. The code to
create the log directory -- especially for production -- has been left
alone because creating the directory as needed makes the most sense in
that situation.

Unfortunately I had a brain/bzr interface malfunction and removed the
logs directory after comitting an earlier fix.  For that reason I will
be self-reviewing this MP.
-- 
https://code.launchpad.net/~benji/launchpad/bug-1011793-2/+merge/110338
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file '.bzrignore'
--- .bzrignore	2012-06-02 03:05:06 +0000
+++ .bzrignore	2012-06-14 14:03:21 +0000
@@ -1,6 +1,5 @@
 .tags
 bzr-version-info.py
-logs
 logs/*
 +*
 sourcecode/*
@@ -78,3 +77,4 @@
 callgrind.out.*
 scripts/mlist-sync.py
 ./celerybeat-schedule
+!logs/README.txt

=== added directory 'logs'
=== added file 'logs/README.txt'
--- logs/README.txt	1970-01-01 00:00:00 +0000
+++ logs/README.txt	2012-06-14 14:03:21 +0000
@@ -0,0 +1,2 @@
+This directory is included in revision control so that it exists for
+tests that need to write logs.