← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~ivo-kracht/launchpad/bug-425934 into lp:launchpad

 

Review: Approve code

This branch looks good.

It might be slightly better to move the comment about commands having to be indented to just before the "if" because the "lower" line doesn't have anything to do with indentation.  You could optionally also add a comment about the fact that we ignore capitalisation in commands just before the "lower" line.
-- 
https://code.launchpad.net/~ivo-kracht/launchpad/bug-425934/+merge/110786
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References