launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

The proposal to merge lp:~cjwatson/launchpad/change-override-forbid-release-stable into lp:launchpad has been updated.

Description changed to:

== Summary ==

Bug 530020: override changes can result in stranded publications that will never be published, since the RELEASE pockets of released DSes in the primary Ubuntu archive are immutable.

== Proposed fix ==

Move the cannotModifySuite method from the publisher down to DistroSeries so that changeOverride can use it (there are enough copies of this logic already without adding more!), and raise an exception in changeOverride if that indicates that the newly-created publication would be stranded.

== Implementation details ==

I cleaned up some useless "current = self" code in changeOverride.  This made sense before the removal of secure publication records in r7659.7.1, but now it's just more typing.

== LOC Rationale ==

+42.  I'm doing this so that I can land https://code.launchpad.net/~cjwatson/launchpad/export-change-override/+merge/109549, which is looking like it should come out at least 76 lines in credit once the old script is removed, so I think this will be OK.

== Tests ==

bin/test -vvct test_publishing.TestChangeOverride

== Demo and Q/A ==

On dogfood, attempt to run 'change-override.py -s precise -p extra base-files' and 'change-override.py -s quantal -p extra base-files'; these should respectively fail and succeed.

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/change-override-forbid-release-stable/+merge/110942
-- 
https://code.launchpad.net/~cjwatson/launchpad/change-override-forbid-release-stable/+merge/110942
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.