launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

William Grant has proposed merging lp:~wgrant/launchpad/bug-1015289 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1015289 in Launchpad itself: "Please revert to old dating system"
  https://bugs.launchpad.net/launchpad/+bug/1015289

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/bug-1015289/+merge/111139

This branch fixes bug #1015289, an issue that I raised during the fixing of bug #999662. 

DistributionSourcePackage:+index used to always show the age of publications, which got sort of ridiculous (eg. "220 weeks ago"). Bug #999662 was fixed by changing it to show a date. But that makes it pretty awkward to see when a very recent upload happened, as fmt:date doesn't use an age for even moments-old timestamps. This branch just changes the page to use fmt:approximatedate, which displays an age for timestamps less than a day old, and a date otherwise.
-- 
https://code.launchpad.net/~wgrant/launchpad/bug-1015289/+merge/111139
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/bug-1015289 into lp:launchpad.

=== modified file 'lib/lp/registry/templates/distributionsourcepackage-index.pt'
--- lib/lp/registry/templates/distributionsourcepackage-index.pt	2012-06-14 10:34:55 +0000
+++ lib/lp/registry/templates/distributionsourcepackage-index.pt	2012-06-20 03:21:21 +0000
@@ -162,7 +162,7 @@
         </td>
         <td>
           <tal:date_published condition="row/date_published">
-            <span tal:replace="row/date_published/fmt:date"/>
+            <span tal:replace="row/date_published/fmt:approximatedate"/>
           </tal:date_published>
           <tal:not_published
                condition="not: row/date_published"