launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/test-depends-on-build into lp:maas.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jtv/maas/test-depends-on-build/+merge/111366

This is a change we've been meaning to make, but which we seem to have forgotten for one reason or another.

It seems sensible that running the test suite require a properly built project.  I was getting local test failures, not for the first time, because I ran “make check” or “make test” in a fresh branch without doing a “make build” first.

The cause this time was that the maas-import-pxe-files script needs to call bin/maas, which is built by the “build” target but not by the “test” target.  I could have hacked around it by adding it to “test” as well, but that's just mindless duplication.  I think this dependency makes more sense.


Jeroen
-- 
https://code.launchpad.net/~jtv/maas/test-depends-on-build/+merge/111366
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/test-depends-on-build into lp:maas.

=== modified file 'Makefile'
--- Makefile	2012-06-15 15:09:28 +0000
+++ Makefile	2012-06-21 09:30:37 +0000
@@ -83,7 +83,7 @@
 	$(buildout) install repl
 	@touch --no-create bin/py bin/ipy
 
-test: bin/test.maas bin/test.maastesting bin/test.pserv $(js_enums)
+test: build
 	bin/test.maas
 	bin/test.maastesting
 	bin/test.pserv