launchpad-reviewers team mailing list archive

[Francesco Banconi <francesco.banconi@xxxxxxxxxxxxx>]

Francesco Banconi has proposed merging lp:~frankban/launchpad/bug-1002820-again-and-again into lp:launchpad.

Requested reviews:
  Yellow Squad (yellow)
Related bugs:
  Bug #1002820 in Launchpad itself: "lp.testing.layers.RabbitMQLayer:setUp times out rarely/intermittently in parallel tests"
  https://bugs.launchpad.net/launchpad/+bug/1002820

For more details, see:
https://code.launchpad.net/~frankban/launchpad/bug-1002820-again-and-again/+merge/111608

= Summary =

RabbitMQLayer:setUp still times out.

== Proposed fix ==

Increased the number of retries, and used retries also in _stop (invoked by rabbot layer teardown).
The real diff is here: http://pastebin.ubuntu.com/1054367/

-- 
https://code.launchpad.net/~frankban/launchpad/bug-1002820-again-and-again/+merge/111608
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'versions.cfg'
--- versions.cfg	2012-06-21 19:53:16 +0000
+++ versions.cfg	2012-06-22 15:10:44 +0000
@@ -105,8 +105,9 @@
 # lp-1 Build of lp:~benji/rabbitfixture/longer-timeout revision: r30
 # lp-2 Build of lp:~frankban/rabbitfixture/longer-timeout revision: r32
 # lp-3 Build of lp:~frankban/rabbitfixture/lp3 revision: r33
+# lp-4 Build of lp:~frankban/rabbitfixture/lp4 revision: r34
 # to build: python setup.py sdist
-rabbitfixture = 0.3.3-lp-3
+rabbitfixture = 0.3.3-lp-4
 roman = 1.4.0
 # See http://code.google.com/p/selenium/issues/detail?id=1935 .
 selenium = 2.0rc3-lp-distribute-fix