launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #09112
[Merge] lp:~frankban/launchpad/bug-1011847-again-and-again into lp:launchpad
Francesco Banconi has proposed merging lp:~frankban/launchpad/bug-1011847-again-and-again into lp:launchpad.
Requested reviews:
Yellow Squad (yellow)
Related bugs:
Bug #1011847 in Launchpad itself: "lp.services.webapp.tests.test_error.TestDatabaseErrorViews.test_disconnectionerror_view_integration fails intermittently/rarely in parallel tests"
https://bugs.launchpad.net/launchpad/+bug/1011847
For more details, see:
https://code.launchpad.net/~frankban/launchpad/bug-1011847-again-and-again/+merge/111628
= Summary =
test_disconnectionerror_view_integration still times out.
== Changes ==
Increased the amount of times the connection is retried.
== Tests ==
bin/test -cvvt lp.services.webapp.tests.test_error.TestDatabaseErrorViews.test_disconnectionerror_view_integration
No QA
--
https://code.launchpad.net/~frankban/launchpad/bug-1011847-again-and-again/+merge/111628
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
=== modified file 'lib/lp/services/webapp/tests/test_error.py'
--- lib/lp/services/webapp/tests/test_error.py 2012-06-14 05:18:22 +0000
+++ lib/lp/services/webapp/tests/test_error.py 2012-06-22 15:43:23 +0000
@@ -67,7 +67,7 @@
else:
self.fail("We should have gotten an HTTP error")
- def retryConnection(self, url, retries=60):
+ def retryConnection(self, url, retries=180):
"""Retry to connect to *url* for *retries* times.
Return the file-like object returned by *urllib2.urlopen(url)*.
Follow ups