launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

Review: Approve

Thanks so much for dealing with hiding/showing at the form level instead of each element. Makes a ton more sense. As part of that I don't think you need the variable handles to all of the elements and you can simplify the html setup [see #174 below].

#125
You can take advantage of the setAttrs() to set multiple attributes in one swoop. This can help performance with fewer redraws/etc. 

#174 
You can pass a list of nodes to the append method to avoid the multiple calls and creating the variables if you don't need them.

Example fiddle: http://jsfiddle.net/f4uVD/6/




-- 
https://code.launchpad.net/~sinzui/launchpad/bug-tag-enhacement/+merge/111639
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.