launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

The proposal to merge lp:~cjwatson/launchpad/pcj-reupload-fix into lp:launchpad has been updated.

Description changed to:

== Summary ==

https://code.launchpad.net/~cjwatson/launchpad/pcj-reupload/+merge/111124 didn't quite work, as indicated in the QA notes on bug 334858.

== Proposed fix ==

Add the missing transaction.commit.  We didn't notice this in tests because the test in question didn't set SPR.changelog, so fix that too.

== LOC Rationale ==

+6.  Same rationale as https://code.launchpad.net/~cjwatson/launchpad/pcj-reupload/+merge/111124.

== Tests ==

bin/test -vvct test_packagecopyjob

== Demo and Q/A ==

Same as https://code.launchpad.net/~cjwatson/launchpad/pcj-reupload/+merge/111124.

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/pcj-reupload-fix/+merge/111804
-- 
https://code.launchpad.net/~cjwatson/launchpad/pcj-reupload-fix/+merge/111804
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/pcj-reupload-fix into lp:launchpad.