← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~wallyworld/launchpad/new-team-picker-simple-form into lp:launchpad

 


On 26/06/12 23:55, Curtis Hovey wrote:
> Review: Needs Fixing code
> 
> I suspect lines 512 and 680 will fail in IE 8 because it does not support nth-child(). We fixed a few cases of this recently.
> 
> There are two choices:
> 1. use('selector-css3') to add support for IE8
> 2. replace :nth-child(1) with :first-child which I think is easier to read.
> 


Ah, right you are. And nth-child is used in the picker validation stuff
too from memory. I'll fix that also.


-- 
https://code.launchpad.net/~wallyworld/launchpad/new-team-picker-simple-form/+merge/111781
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References