launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/prep-nodekey-tests into lp:maas.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jtv/maas/prep-nodekey-tests/+merge/112261

As per the migration plan.  Only two things of note:

1. The announcement comment goes in a weird place because there's no way to satisfy both the imports-formatting tool and the lint checker.  We've seen this before.

2. I see no point whatsoever to the setUp method, so I'm removing it.  In fact I'm also adding a branch to do the same for another instance of the same weirdness, in code I just wrote up a migration branch for.  (As per the migration plan I'm not mixing code migration with code changes because they're hard to tell apart in diffs).


Jeroen
-- 
https://code.launchpad.net/~jtv/maas/prep-nodekey-tests/+merge/112261
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/prep-nodekey-tests into lp:maas.

=== modified file 'src/metadataserver/tests/test_models.py'
--- src/metadataserver/tests/test_models.py	2012-06-20 17:52:40 +0000
+++ src/metadataserver/tests/test_models.py	2012-06-27 03:35:23 +0000
@@ -24,11 +24,9 @@
 
 
 class TestNodeKeyManager(DjangoTestCase):
+# Scheduled for model migration on 2012-07-04
     """Test NodeKeyManager."""
 
-    def setUp(self):
-        super(TestNodeKeyManager, self).setUp()
-
     def test_get_token_for_node_registers_node_key(self):
         node = factory.make_node()
         token = NodeKey.objects.get_token_for_node(node)