← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~gz/lp-dev-utils/creds_from_environment into lp:lp-dev-utils

To: Martin Packman <martin.packman@xxxxxxxxxxxxx>
From: Robert Collins <robertc@xxxxxxxxxxxxxxxxx>
Date: Wed, 27 Jun 2012 08:43:20 -0000
In-reply-to: <20120627082728.29177.40909.launchpad@ackee.canonical.com>
Reply-to: mp+112289@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

I haven't reviewed this, but I did glance at it and I don't see where
you use addCleanup, which confused me.

-Rob

-- 
https://code.launchpad.net/~gz/lp-dev-utils/creds_from_environment/+merge/112289
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~gz/lp-dev-utils/creds_from_environment into lp:lp-dev-utils.

References

[Merge] lp:~gz/lp-dev-utils/creds_from_environment into lp:lp-dev-utils
From: Martin Packman, 2012-06-27