launchpad-reviewers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Review: Approve db

Hi. Has this been discussed with the core Launchpad team?

The patch itself looks fine. There are few records in distroseries, so adding the column and setting the default value at the same time is fine.

The new column name is horrible. Can anyone come up with a better name?

(15:19:02) wgrant: stub: My suggestion would be to just make it proposed_not_automatic
(15:19:11) wgrant: stub: The pre-release bit can be handled by unsetting the flag on release :)

This suggestion seems a little more flexible, and doesn't encode the release procedure rules in the data store.

I'm not blocking on the name, as we have worse and it indeed may be the best option.

This patch cannot be applied live, so is targeted correctly for landing and deployment during a fast downtime window.
-- 
https://code.launchpad.net/~laney/launchpad/db-proposed-not-automatic-pre-release/+merge/112134
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~laney/launchpad/db-proposed-not-automatic-pre-release into lp:launchpad/db-devel.