← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~rharding/launchpad/listingnav_yui35 into lp:launchpad

To: mp+112334@xxxxxxxxxxxxxxxxxx
From: Francesco Banconi <francesco.banconi@xxxxxxxxxxxxx>
Date: Wed, 27 Jun 2012 13:36:32 -0000
In-reply-to: <20120627120721.28221.74968.launchpad@ackee.canonical.com>
Reply-to: mp+112334@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code*

This branch looks good Richard, thank you.
As we discussed on IRC, you added 'node' as a requirement because in the code a NodeList is used at one point.
The tests pass.
-- 
https://code.launchpad.net/~rharding/launchpad/listingnav_yui35/+merge/112334
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~rharding/launchpad/listingnav_yui35 into lp:launchpad
From: Richard Harding, 2012-06-27