launchpad-reviewers team mailing list archive

["j.c.sackett" <jcsackett@xxxxxxxxxxxxx>]

Review: Approve

Curtis--

This looks good. Just one style note.

In a few places (line 226 or 311, for example): It looks like you're doing
pythonic brace/paren closure in places. I think for javascript we have the
closing brace at the same tab level as the opening call, rather than at the
tab level of the enclosed lines.

In other words, I believe we prefer:

  some_call(function () {
    stuff; 
  });

Rather than:

  some_call(function () {
    stuff;
    });

-- 
https://code.launchpad.net/~sinzui/launchpad/bug-tag-completions/+merge/112580
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.