launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #09356
Re: [Merge] lp:~sinzui/launchpad/bug-tag-completions into lp:launchpad
Hi. Jon, Rick.
I outdented the close of the methods calls that contain anonymous functions
I removed the redundant "bug_" from the namespace.
autocomplete is a private namespace var declared on line 24 of the module. The module has lots of hidden, untestible parts because of the structure of the entire module.
I quoted the attribute value in the selectors. I was inconsistent.
I will play with the widget and CSS in another branch.
--
https://code.launchpad.net/~sinzui/launchpad/bug-tag-completions/+merge/112580
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
References