launchpad-reviewers team mailing list archive

[Brad Crittenden <bac@xxxxxxxxxxxxx>]

Review: Approve code

Hi John,

Thanks for the fix and going the extra step to convert to a unit test.

Rather than login(ANONYMOUS) I think using a with statement with the 'person_logged_in' context manager is cleaner. 

typo: hello() returns Anonymous 

Otherwise it looks good.
-- 
https://code.launchpad.net/~jameinel/launchpad/py27-xmlrpc-auth-1019292/+merge/112792
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.