launchpad-reviewers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Stuart Bishop has proposed merging lp:~stub/launchpad/staging into lp:launchpad.

Requested reviews:
  Stuart Bishop (stub)

For more details, see:
https://code.launchpad.net/~stub/launchpad/staging/+merge/112928

= Summary =

The fast downtime deployment script, full-update.py, is broken.

== Proposed fix ==

Fix it.

== Pre-implementation notes ==

== LOC Rationale ==

== Implementation details ==

== Tests ==

== Demo and Q/A ==


= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  database/replication/Makefile
  database/schema/full-update.py

./database/replication/Makefile
      74: Line exceeds 80 characters.
./database/schema/full-update.py
       7: '_pythonpath' imported but unused
-- 
https://code.launchpad.net/~stub/launchpad/staging/+merge/112928
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'database/schema/full-update.py'
--- database/schema/full-update.py	2012-01-01 03:20:03 +0000
+++ database/schema/full-update.py	2012-07-01 08:28:26 +0000
@@ -52,6 +52,7 @@
     # Fake expected command line arguments and global log
     options.commit = True
     options.partial = False
+    options.ignore_slony = False
     upgrade.options = options
     upgrade.log = log
     # Invoke the database schema upgrade process.