← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~stevenk/launchpad/auditor-layer into lp:launchpad

 

Why do you use setattr in the AuditorServer class's setUp method?

    setattr(
        self, 'service_config',
        dedent("""\
            [auditor]
            port: %d
            """ % (self.config.port)))

I would think this would work:

    self.service_config = ...


Under most conditions distribution names are case-insensitive so I am
curious why there are two Djangos in versions.cfg:

+django = 1.4
+Django = 1.4

-- 
https://code.launchpad.net/~stevenk/launchpad/auditor-layer/+merge/112962
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References