launchpad-reviewers team mailing list archive

[Ivo Kracht <ivo.kracht@xxxxxx>]

Ivo Kracht has proposed merging lp:~ivo-kracht/launchpad/bug-1013281 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1013281 in Launchpad itself: "bug lists implies the bug age is a milestone"
  https://bugs.launchpad.net/launchpad/+bug/1013281

For more details, see:
https://code.launchpad.net/~ivo-kracht/launchpad/bug-1013281/+merge/113062

I just added the new icon into the template. There are no tests for this as far as I know. If I missed something, the ec2 test will reveal it.

Pre-imp call with adeuring and sinzui

to test it just open any bug listing with bug age being viewed.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/canonical/launchpad/icing/inline-sprites-2.css.in
  lib/canonical/launchpad/images/aging.png
  lib/lp/bugs/templates/buglisting.mustache


-- 
https://code.launchpad.net/~ivo-kracht/launchpad/bug-1013281/+merge/113062
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~ivo-kracht/launchpad/bug-1013281 into lp:launchpad.

=== modified file 'lib/canonical/launchpad/icing/inline-sprites-2.css.in'
--- lib/canonical/launchpad/icing/inline-sprites-2.css.in	2012-06-02 03:10:14 +0000
+++ lib/canonical/launchpad/icing/inline-sprites-2.css.in	2012-07-02 15:06:23 +0000
@@ -29,3 +29,6 @@
     background-image: url(/@@/zoom-out.png); /* sprite-ref: icon-sprites */
     background-repeat: no-repeat;
     }
+.aging {
+    background-image: url(/@@/aging.png); /* sprite-ref: icon-sprites */
+    background-repeat: no-repeat;
\ No newline at end of file

=== added file 'lib/canonical/launchpad/images/aging.png'
Binary files lib/canonical/launchpad/images/aging.png	1970-01-01 00:00:00 +0000 and lib/canonical/launchpad/images/aging.png	2012-07-02 15:06:23 +0000 differ
=== modified file 'lib/lp/bugs/templates/buglisting.mustache'
--- lib/lp/bugs/templates/buglisting.mustache	2012-01-12 11:28:03 +0000
+++ lib/lp/bugs/templates/buglisting.mustache	2012-07-02 15:06:23 +0000
@@ -55,7 +55,7 @@
                 </span>
             {{/show_reporter}}
             {{#show_datecreated}}
-                <span class="sprite milestone field">
+                <span class="sprite aging field">
                     {{age}}
                 </span>
             {{/show_datecreated}}