launchpad-reviewers team mailing list archive

[Benji York <benji@xxxxxxxxxxxxx>]

Review: Approve code

This looks good.  I like the way the data for the changes is
packaged/unpacked.

The only thing I spotted were some extra parens:

    raise QueueInconsistentStateError(
        "No rights to override from %s" % (
            binarypackage.component.name))

Since the % expression is already in parenthesis, those around
"binarypackage.component.name" are unnecessary.

-- 
https://code.launchpad.net/~cjwatson/launchpad/queue-api-refactor-overrides/+merge/113074
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.