launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

Review: Approve code

Thanks Ian. I'm reviewing the code, but leave the question on the select dropdown to others. It seems a bit simple to turn over into the larger UI widget, but there's something to be said for consistant look/feel.

#9
The var is already not attached to the namespace so it's forced private. I wouldn't prefix it with an underscore unless it was attached to an object instance and you wanted to indicate it should be private on that object.

#158
subscriptionpolicyedit is a bit hard on the eyes. I generally find that once a name gets past two distinct words, breaking up with _ helps. For instance, I notice you used team_subscriptionpolicy_data, and think that'd be a good standard to keep with. subscriptionpolicy_XXXXX.

#775
Typo: grupo


-- 
https://code.launchpad.net/~wallyworld/launchpad/new-team-picker-enhanced-form/+merge/113020
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.