launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

Review: Approve

Thanks, couple of points, but looks ok.

#245
I'm not familiar with the code, so changing a read only value makes me nervous. I want to make sure this is ok/safe?

#427/#436
Wouldn't these just turn into len(self.sources) vs accessing the now 'private' _sources to get the count?


-- 
https://code.launchpad.net/~cjwatson/launchpad/queue-api-readonly/+merge/113202
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.