launchpad-reviewers team mailing list archive

["j.c.sackett" <jcsackett@xxxxxxxxxxxxx>]

> #50
> It looks like the validate method returns true if get_vote isn't null, and
> never checks the parent class in that case. I would think that if get_vote was
> true, it'd not return anything yet, but return the parents validate status. It
> would only return false if the validation failed at this point? Is this setup
> correct?

You may be right, but given vote's work now, I don't think it's in scope of this branch to alter the behavior. I was just updating the code with Y.Base

> #76
> The renderUI method should just be able to go away since it's not doing
> anything in addition to the parent class's implementation. There's no need to
> override it just to call the parent.

Killed it, good spot, thanks.
-- 
https://code.launchpad.net/~jcsackett/launchpad/comment-cleanup/+merge/113116
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.