launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~abentley/launchpad/all-url-support into lp:launchpad

To: Aaron Bentley <aaron@xxxxxxxxxxxxx>
From: Steve Kowalik <stevenk@xxxxxxxxxx>
Date: Tue, 03 Jul 2012 23:35:23 -0000
In-reply-to: <20120703201719.18378.26730.launchpad@ackee.canonical.com>
Reply-to: mp+113294@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

Even though this branch is a little bit large, it looks like fantastic work, and I think that you've managed to reduce the complexity as well as the LOC count is impressive.

My only concern with this branch is that you have removed code from branchlookup which would only return public branches -- are you concerned about leaking information there? Since I am, and the new code does not seem to have anything like it, so could you ally my concerns?
-- 
https://code.launchpad.net/~abentley/launchpad/all-url-support/+merge/113294
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~abentley/launchpad/all-url-support into lp:launchpad
From: Aaron Bentley, 2012-07-03