launchpad-reviewers team mailing list archive

[Ivo Kracht <ivo.kracht@xxxxxx>]

Ivo Kracht has proposed merging lp:~ivo-kracht/launchpad/bug-562532 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #562532 in Launchpad itself: "The bug status table should make use of the edit sprite icon"
  https://bugs.launchpad.net/launchpad/+bug/562532

For more details, see:
https://code.launchpad.net/~ivo-kracht/launchpad/bug-562532/+merge/113414

I changed the implementation of the “Edit“ button from <img> tags to a sprite icon to eleminate one page request from a browser.

Pre-imp call with adeuring

tests:
./bin/test bugs -vvt bugtask-display-widgets.txt displaying-bugs-and-tasks.txt

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/bugs/templates/bugtask-tasks-and-nominations-table-row.pt

-- 
https://code.launchpad.net/~ivo-kracht/launchpad/bug-562532/+merge/113414
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~ivo-kracht/launchpad/bug-562532 into lp:launchpad.

=== modified file 'lib/lp/bugs/templates/bugtask-tasks-and-nominations-table-row.pt'
--- lib/lp/bugs/templates/bugtask-tasks-and-nominations-table-row.pt	2012-06-16 14:11:34 +0000
+++ lib/lp/bugs/templates/bugtask-tasks-and-nominations-table-row.pt	2012-07-04 15:07:31 +0000
@@ -74,7 +74,7 @@
              tal:content="status/title" />
           <a href="+editstatus" style="margin-left: 3px"
              tal:attributes="href data/edit_link">
-            <img class="editicon" src="/@@/edit" />
+            <button class="lazr-btn yui3-activator-act">Edit</button>
           </a>
         </tal:edit-status>
       </div>
@@ -91,7 +91,7 @@
            tal:content="data/importance_title" />
         <a href="+editstatus" style="margin-left: 3px"
            tal:attributes="href data/edit_link">
-          <img class="editicon" src="/@@/edit" />
+          <button class="lazr-btn yui3-activator-act">Edit</button>
         </a>
       </div>
     </td>