launchpad-reviewers team mailing list archive

[Abel Deuring <abel.deuring@xxxxxxxxxxxxx>]

On 05.07.2012 19:41, j.c.sackett wrote:
> Review: Needs Information
> 
> Thanks, Ivo. This looks good.
> 
> It looks like you've copy pasted test_decoratedresultset from another file; the headings are all wrong (it's talking about CVEs, buglinktarget, &c).
> 
> That said, I'm not sure that file is even needed--I gather from reading it it's meant to gather the doctest you modified, but that test is already gathered and run without it. Can you try deleting it and making sure your tests are run?
> 

[playing the "proxy" for Ivo:]

right, the file was copied, and the comments need to be changed. But the
file itself is necessary: Without it, the doctest is simply not
executed. (Or do we have other ways to let the doctest really run?)

Ivo is currently "recovering" from his internship and back in college
tomorrow, so I'll "seize" his branch and fix the comments.

Abel

-- 
https://code.launchpad.net/~ivo-kracht/launchpad/bug-728129/+merge/113612
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.