launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/robie-hacking-fix into lp:maas.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jtv/maas/robie-hacking-fix/+merge/113707

Robie reported this omission.  We'll need to keep the addition even when we replace maas-import-isos by maas-import-pxe-files.

When following the steps in HACKING.txt, bin/maas will already have been built.  So no major changes are needed.


Jeroen
-- 
https://code.launchpad.net/~jtv/maas/robie-hacking-fix/+merge/113707
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/robie-hacking-fix into lp:maas.

=== modified file 'HACKING.txt'
--- HACKING.txt	2012-07-05 09:47:07 +0000
+++ HACKING.txt	2012-07-06 09:10:25 +0000
@@ -206,8 +206,9 @@
 Now run ``maas-import-isos`` to download Ubuntu precise and create the
 necessary MAAS profiles::
 
-    $ sudo http_proxy=$http_proxy ./scripts/maas-import-isos
+    $ sudo http_proxy=$http_proxy PATH=$PATH:./bin ./scripts/maas-import-isos
 
+You need the PATH addition because the script will want to run bin/maas.
 The http_proxy variable is only needed if you're downloading through a
 proxy; "sudo" wouldn't pass it on to the script without the assignment.
 Or if you don't have it set but do want to download through a proxy, pass