launchpad-reviewers team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

>> 2. I expected canBePrivate to check of the branch target is a
>> project with a commercial subscription. Doing this allows new
>> projects to create a private trunk and start working minutes
>> after registration.


> If I add the commercial subscription check to
> canBePrivate(), this will allow the user to also make the branch
> embargoed security or user data as well as proprietary. Do I need to
> restrict the choice to proprietary in this case?

We don't care about the specific kind of private we select. We just want to ensure that we can make any branch some form of private because out projects have commercial subscriptions. We want to fix this case:
    https://bugs.launchpad.net/launchpad/+bug/409898
Lp may have private branches, but since the default is public, none of us can state a branch is private. We have to wait for a WebOps to help us. Stub used his super DB powers to force it private. No one should do risk data integrity to ensure confidential information is not disclosed.  
-- 
https://code.launchpad.net/~wallyworld/launchpad/make-private-branches-527900/+merge/113532
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.