launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~wgrant/launchpad/bugsummary-v2-db-1 into lp:launchpad

To: William Grant <me@xxxxxxxxxxxxxxxxxx>
From: Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>
Date: Mon, 09 Jul 2012 06:54:18 -0000
In-reply-to: <20120705071619.2091.85180.launchpad@ackee.canonical.com>
Reply-to: mp+113500@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve db

Looks fine.

I assume all the _idx2 names are going to be renamed after other indexes are dropped.

It might be helpful for us to have a test helper that does "SET enable_seqscan=off; EXPLAIN (FORMAT JSON) $query;" and checks the result to make sure a particular index is being hit.
-- 
https://code.launchpad.net/~wgrant/launchpad/bugsummary-v2-db-1/+merge/113500
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~wgrant/launchpad/bugsummary-v2-db-1 into lp:launchpad
From: William Grant, 2012-07-05