launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code

51	@property
52	+ def branch_ids(self):
53	+ if not 'branch_ids' in self.metadata:
54	+ return []
55	+ return self.metadata['branch_ids']

Isn't that equivalent to "return self.metadata.get('branch_ids', [])"?

We really need to rearchitect the tests for that job, but I guess it's OK for now. Otherwise this looks good, thanks.
-- 
https://code.launchpad.net/~stevenk/launchpad/teach-rasj-about-branches/+merge/114106
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.