launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

Review: Needs Information

Thank Iain. I think having the split tests is ok. I might have passed in the string for the property 'proposed_not_automatic' for instance, and used getattr/setattr to test and check the value myself, but it works.

I don't see any LoC qualification in the MP. Do you have a credit currently?

I want to make sure the removed imports in #164 are unused imports then?

Other than that, I don't see anything. Marking needs information for the moment.
-- 
https://code.launchpad.net/~laney/launchpad/proposed-notautomatic/+merge/113921
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.