launchpad-reviewers team mailing list archive

[Brad Crittenden <bac@xxxxxxxxxxxxx>]

Thanks for the review Benji.

The tips for better formatting the reST file are appreciated and I've made the changes.  The style, formatting, and grammar fixes have been made.

The XXX needs to stay but I have provided an explanatory comment.

As for the running-in-container question, I defer to Gary's blog post, where he quotes Serge:

gary_poster: how can code determine if it is being run within an LXC container?
gary_poster asked Serge Hallyn if there were a reliable way for code to determine if it is being run within an LXC container.   Serge said yes, and gave these steps (note that this may be Ubuntu-specific; Ubuntu-specific is good enough for us right now).
if /bin/running-in-container is present (precise and above, always), run it and check for 0 return value
else, if lxc-is-container is not present, assume lxcguest is not installed and you're not in a container (or are in trimmed container)
else, run lxc-is-container, if 0, you're in a container, if 1 you're not

(http://codesinger.blogspot.com/2012/07/yellow-squad-weekly-retrospective.html)

So, according to Serge, the absence of either of those test executables should indicate false.

-- 
https://code.launchpad.net/~bac/lpsetup/mv-initialize-lxc/+merge/114239
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~bac/lpsetup/mv-initialize-lxc into lp:lpsetup.