← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~rharding/launchpad/lpyui-dep into lp:launchpad

To: mp+114430@xxxxxxxxxxxxxxxxxx
From: "j.c.sackett" <jcsackett@xxxxxxxxxxxxx>
Date: Thu, 12 Jul 2012 14:19:36 -0000
In-reply-to: <20120712140318.6532.34518.launchpad@ackee.canonical.com>
Reply-to: mp+114430@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

This looks ok to me, but I'll be the first to point out that I'm not a make/buildout expert. It may be worth following up with others with more experience in this part of our code.
-- 
https://code.launchpad.net/~rharding/launchpad/lpyui-dep/+merge/114430
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~rharding/launchpad/lpyui-dep into lp:launchpad
From: Richard Harding, 2012-07-12