← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~wgrant/launchpad/improve-branch-edit-type into lp:launchpad

 

Review: Approve

Thanks William. One minor point.

At line #60 you have a comment about using the widget vocabulary in `getInformationTypesToShow`, but you actually do that vocal step on #103, in setUpWidgets. Might be worth moving the comment to the place where the code is actually happening.
-- 
https://code.launchpad.net/~wgrant/launchpad/improve-branch-edit-type/+merge/114591
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References