launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

Raphaël Badin has proposed merging lp:~rvb/maas/disable-store-result into lp:maas.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~rvb/maas/disable-store-result/+merge/115079

This very simple branch simply sets CELERY_IGNORE_RESULT to True in celeryconfig.py.  We're already never relying on the result of a task to be available so this is only an optimization (see [1] for details)

[1] http://celery.readthedocs.org/en/latest/userguide/tasks.html?highlight=task%20result#ignore-results-you-don-t-want
-- 
https://code.launchpad.net/~rvb/maas/disable-store-result/+merge/115079
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/disable-store-result into lp:maas.

=== modified file 'etc/celeryconfig.py'
--- etc/celeryconfig.py	2012-07-11 09:06:57 +0000
+++ etc/celeryconfig.py	2012-07-16 08:13:31 +0000
@@ -49,3 +49,7 @@
 )
 
 CELERY_ACKS_LATE = True
+
+# Do not store the tasks return values (aka tombstones);
+# This improves performance.
+CELERY_IGNORE_RESULT = True