launchpad-reviewers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Stuart Bishop has proposed merging lp:~stub/launchpad/trivial into lp:launchpad.

Requested reviews:
  Stuart Bishop (stub)
Related bugs:
  Bug #951401 in Launchpad itself: "parse-ppa-apache-logs failing (missing files)"
  https://bugs.launchpad.net/launchpad/+bug/951401

For more details, see:
https://code.launchpad.net/~stub/launchpad/trivial/+merge/115139

= Summary =

New ftq() helpers were created in the public schema, leaving the old ones in the ts2 schema.

== Proposed fix ==

Drop the obsolete ones. We are only using the new ones by accident because that is how the search paths are setup.

Also update security.cfg to cope with the move. Previously, the helpers were getting permissions set with everything else in the previously automatically maintained ts2 schema. I'm not sure how the new helpers are being granted their permissions.

== Pre-implementation notes ==

== LOC Rationale ==

== Implementation details ==

== Tests ==

== Demo and Q/A ==


= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  database/schema/patch-2209-24-2.sql
  database/schema/security.cfg


== Schema ==
-- 
https://code.launchpad.net/~stub/launchpad/trivial/+merge/115139
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== added file 'database/schema/patch-2209-24-2.sql'
--- database/schema/patch-2209-24-2.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2209-24-2.sql	2012-07-16 13:21:29 +0000
@@ -0,0 +1,7 @@
+SET client_min_messages = ERROR;
+
+-- ftq() moved to public. Remove the old code to avoid confusion.
+DROP FUNCTION ts2.ftq(text);
+DROP FUNCTION ts2._ftq(text);
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 24, 2);

=== modified file 'database/schema/security.cfg'
--- database/schema/security.cfg	2012-07-11 22:17:05 +0000
+++ database/schema/security.cfg	2012-07-16 13:21:29 +0000
@@ -45,6 +45,8 @@
 public.exclusivelocks                      =
 public.featureflag                         = SELECT
 public.fticache                            =
+public.ftq(text)                           = EXECUTE
+public._ftq(text)                          = EXECUTE
 public.generate_openid_identifier()        = EXECUTE
 public.getlocalnodeid()                    = EXECUTE
 public.is_blacklisted_name(text, integer)  = EXECUTE