launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Thanks for reviewing.
> 
> I life this branch, but I think the rule that permits me to subscribe an
> unshared user to branch that I cannot edit contradicts your own work to to
> reconcile APGs ans AAGs with subscriptions. See my questions below.
> 

Just to clarify, in the above, s/cannot/can. You can only subscribe a user to a branch you *can* edit.

> >
> >      def test_owner_sees_own_branches(self):
> > -        # Users can always see the branches that they own, as well as
> public
> > -        # branches.
> > +        # Users can always see the branches that they own, those their own
> > +        # branches are stacked on, as well as public branches.
> 
> The comment is not true. Project maintainers can remove APG and AAG
> access to a branch from an owner. Private teams cannot access their
> personal branches at this very moment because there is no project to
> create the APG or AAG. We need to fix this case.
> 
> Is this test wrong, or is this just old code that will be superseded?
>

This is an existing test which has been modified in this branch to account for the fact that one of the stacked on branches is now subscribed to by the act of subscribing to the top branch. Any other problems with the test as a result of the new disclosure rules will be addressed separately as part of the final disclosure cleanup.


> > +    def getInvisibleArtifacts(person, branches=None, bugs=None):
> > +        """Return the artifacts which are not shared with person.

> 
> This is dangerous like inTeam(). I think we want a comment in this to remind
> everyone that this method cannot be exported. It is for internal use only.

Yes. Done.


-- 
https://code.launchpad.net/~wallyworld/launchpad/view-private-stacked-branch2-393566/+merge/115112
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.