← Back to team overview

launchpad-reviewers team mailing list archive

Re: lp:~wallyworld/launchpad/information-type-verbosity-1015509 into lp:launchpad

 


On 17/07/12 10:26, Curtis Hovey wrote:
> Review: Approve code + ui
> 
> I think user data and propriety are still a little awkward. Actually. I like the use of "confidential". "User data" is inherently awkward. Do we dare look for something like "confidential" or "personal" this late? Are we missing a concept of a group of people who with with personal information?
> 

We could use 'Private' instead of 'Proprietary' for
InformationType.PROPRIETARY. This type is excluded behind a feature flag
so is not currently visible and 'Private' fits well with the concept of
Private Projects, which I think you will need a commercial subscription for?

As for USERDATA, I do really like 'Confidential'. I am happy to change
the wording as part of this branch.

I don't think it is too late to make these changes. I think they are
worthwhile and it would be nice to get it right before we go to full beta.

> Well This is an good improvement .You can land this, but I ask that you wait a few hours, the re-read this in case you think of a better phrase for the last two.
>

How about the above?



-- 
https://code.launchpad.net/~wallyworld/launchpad/information-type-verbosity-1015509/+merge/115253
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References