launchpad-reviewers team mailing list archive

[Huw Wilkins <huw.wilkins@xxxxxxxxxxxxx>]

Huw Wilkins has proposed merging lp:~huwshimi/launchpad/broken-tag-limit-1025493 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~huwshimi/launchpad/broken-tag-limit-1025493/+merge/115270

The tag-list class was changed to data-list in a recent cleanup of mine, but I missed the change in the javascript to limit the number of tags displayed by default on bug list pages. This branch fixes that.
-- 
https://code.launchpad.net/~huwshimi/launchpad/broken-tag-limit-1025493/+merge/115270
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~huwshimi/launchpad/broken-tag-limit-1025493 into lp:launchpad.

=== modified file 'lib/lp/bugs/javascript/bugtarget_portlet_bugtags.js'
--- lib/lp/bugs/javascript/bugtarget_portlet_bugtags.js	2012-02-10 10:07:48 +0000
+++ lib/lp/bugs/javascript/bugtarget_portlet_bugtags.js	2012-07-17 05:28:19 +0000
@@ -52,7 +52,7 @@
         portlet.prepend(response.responseText);
         var show_more_link = Y.one('#show-more-tags-link');
         var show_fewer_link = Y.one('#show-fewer-tags-link');
-        var tag_list = Y.all('.tag-list li');
+        var tag_list = portlet.all('.data-list li');
         if (tag_list.size() > 20) {
             var extra_tags = tag_list.slice(20);
             extra_tags.addClass('hidden');

=== modified file 'lib/lp/bugs/javascript/tests/test_bugtarget_portlet_bugtags.js'
--- lib/lp/bugs/javascript/tests/test_bugtarget_portlet_bugtags.js	2012-07-06 06:02:33 +0000
+++ lib/lp/bugs/javascript/tests/test_bugtarget_portlet_bugtags.js	2012-07-17 05:28:19 +0000
@@ -20,7 +20,7 @@
             mockio.success({
                 responseText:
                     '<div class="test-wrapper">' +
-                    '<h2>Tags</h2><ul class="tag-list">' +
+                    '<h2>Tags</h2><ul class="data-list">' +
                     '</ul></div>',
                 responseHeaders: {'Content-type': 'text/html'}});
             Y.Assert.areEqual('/launchpad/+bugtarget-portlet-tags-content',
@@ -34,10 +34,10 @@
             mockio.success({
                 responseText:
                     '<div class="test-wrapper">' +
-                    '<h2>Tags</h2><ul class="tag-list">' +
+                    '<h2>Tags</h2><ul class="data-list">' +
                     '</ul></div>',
                 responseHeaders: {'Content-type': 'text/html'}});
-            var tags = Y.all('.tag-list li');
+            var tags = Y.all('.data-list li');
             var show_more_link = Y.one('#show-more-tags-link');
             var show_fewer_link = Y.one('#show-fewer-tags-link');
             Y.Assert.areEqual(0, tags.size(), 'The list should be empty');
@@ -52,7 +52,7 @@
         test_twenty_tags_or_fewer: function() {
             var mockio = new Y.lp.testing.mockio.MockIo();
             var response = '<div class="test-wrapper">' +
-                '<h2>Tags</h2><ul class="tag-list">';
+                '<h2>Tags</h2><ul class="data-list">';
             var i;
             module.setup_taglist({io_provider: mockio});
             for (i=0; i<=5; i++) {
@@ -63,7 +63,7 @@
             mockio.success({
                 responseText: response,
                 responseHeaders: {'Content-type': 'text/html'}});
-            var tags = Y.all('.tag-list li');
+            var tags = Y.all('.data-list li');
             var show_more_link = Y.one('#show-more-tags-link');
             var show_fewer_link = Y.one('#show-fewer-tags-link');
             Y.assert(tags.size() <= 20,
@@ -77,7 +77,7 @@
         test_more_than_twenty_tags: function() {
             var mockio = new Y.lp.testing.mockio.MockIo();
             var response = '<div class="test-wrapper">' +
-                '<h2>Tags</h2><ul class="tag-list">';
+                '<h2>Tags</h2><ul class="data-list">';
             var i;
             module.setup_taglist({io_provider: mockio});
             for (i=0; i<=22; i++) {
@@ -88,7 +88,7 @@
             mockio.success({
                 responseText: response,
                 responseHeaders: {'Content-type': 'text/html'}});
-            var tags = Y.all('.tag-list li');
+            var tags = Y.all('.data-list li');
             var show_more_link = Y.one('#show-more-tags-link');
             var show_fewer_link = Y.one('#show-fewer-tags-link');
             var tag_count = tags.size();