launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

Richard Harding has proposed merging lp:~rharding/launchpad/backout_yui into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~rharding/launchpad/backout_yui/+merge/115331

back out 15635
-- 
https://code.launchpad.net/~rharding/launchpad/backout_yui/+merge/115331
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rharding/launchpad/backout_yui into lp:launchpad.

=== modified file 'buildout.cfg'
--- buildout.cfg	2012-07-16 15:41:14 +0000
+++ buildout.cfg	2012-07-17 12:51:51 +0000
@@ -4,7 +4,6 @@
 [buildout]
 parts =
     yui-default
-    yui-3.5
     scripts
     filetemplates
     tags
@@ -43,18 +42,22 @@
 command =
     mkdir -p ${buildout:yui-directory}/yui-${:yui_version}
     rm -rf ${buildout:yui-directory}/yui-${:yui_version}/*
-    unzip -q download-cache/dist/yui_${:yui_version}.zip -d /tmp/yui-${:yui_version}
-    mv /tmp/yui-${:yui_version}/yui/build/* ${buildout:yui-directory}/yui-${:yui_version}
-    rm -rf /tmp/yui-${:yui_version}
+    tar -zxf download-cache/dist/yui-${:yui_version}.tar.gz \
+        --wildcards --strip-components 2 \
+        -C ${buildout:yui-directory}/yui-${:yui_version} \
+        '*/build'
 
 [yui-default]
 <= yui
 yui_version = ${versions:yui}
 
+[yui-3.4]
+<= yui
+yui_version = 3.4.1
+
 [yui-3.5]
-<= yui
-yui_version = 3.5.1
-
+<=yui
+yui_version = 3.5.0pr1
 
 [filetemplates]
 recipe = z3c.recipe.filetemplate

=== modified file 'lib/lp/app/templates/base-layout-macros.pt'
--- lib/lp/app/templates/base-layout-macros.pt	2012-07-16 15:28:40 +0000
+++ lib/lp/app/templates/base-layout-macros.pt	2012-07-17 12:51:51 +0000
@@ -89,7 +89,7 @@
 
   <tal:js-loader condition="request/features/js.combo_loader.enabled">
    <script type="text/javascript"
-        tal:attributes="src string:${combo_url}/?${yui_version}/yui/yui-min.js&amp;lp/meta.js&amp;${yui_version}/loader/loader-min.js"></script>
+        tal:attributes="src string:${combo_url}/?yui/yui/yui-min.js&amp;lp/meta.js&amp;yui/loader/loader-min.js"></script>
    <script type="text/javascript" tal:content="string:
         var raw = null;
         if (LP.devmode) {
@@ -98,11 +98,10 @@
         YUI.GlobalConfig = {
             combine: true,
             comboBase: '${combo_url}/?',
-            root: '${yui_version}/',
+            root: 'yui/',
             filter: raw,
             debug: ${yui_console_debug},
             fetchCSS: false,
-            maxURLLength: 2500,
             groups: {
                 lp: {
                     combine: true,